Hi,

On Sun, 20 Jan 2008, Steffen Prohaska wrote:

> I pushed an updated patch to work/install-fewer.

Thanks.

> BTW, "git diff --text" works pretty well to review changes in 
> ReleaseNotes.rtf.

I used "git diff -a" ;-)

> On Jan 19, 2008, at 11:57 PM, Steffen Prohaska wrote:
> 
> > On Jan 19, 2008, at 11:42 PM, Johannes Schindelin wrote:
> > 
> > > > The last list contains commands that I think should be installed:
> > > > 
> > > > git-citool
> > > 
> > > AFAICT this is not built anymore by git.git.
> > 
> > I ran "rm /bin/git*" and did a fresh install.  I'll check
> > again.
> > 
> > If it is still built, I'll exclude it from the installer.
> 
> It is built by git.git.  It's listed in git-gui/Makefile as
> 
>    GITGUI_BUILT_INS = git-citool
> 
> I see two options
> - exclude it from msysgit's Git-installer.
> - propose upstream to remove it and wait.
> 
> git-citool works and therefore I tend to leave it in the
> installer.

Let's leave it, and not care about it being the same as git-gui.

> > > > git-gui
> > > > git-gui.tcl
> > > 
> > > Do we really need both? Or is the second just a left-over from an old
> > > install?
> > 
> > dunno, will check.
> 
> The current implementation needs both.  I propose to leave this
> until 1.5.4 is released.  Maybe we should cleanup afterwards?

Maybe.

Thanks,
Dscho

Reply via email to