Hi, Johannes Schindelin, thanks for the help with push, mob & co. I'll follow your instructions shortly.
On Jan 23, 7:42 am, Johannes Schindelin wrote: > Basically because I am way more familiar with standard C libraries. Is > there a performance hit, or any other problem with mixing [standard C > libraries and Win32 API]? I'm not aware of any performance or any other issues, except: - a stronger dependency on a particular implementation of C run-time libraries; - a requirement to remember two sets of API. However, as on Jan 23, 5:31 pm, Johannes Sixt wrote: > BTW, lstrcpyn is much better than strncpy because it properly NUL terminates > the destination (and does not fill the buffer with NULs if the source is > short) we might want to lean towards Win32 API for Cheetah. On Jan 23, 8:59 am, Johannes Schindelin wrote: > On Wed, 23 Jan 2008, [EMAIL PROTECTED] wrote: > > I think this also needs to be changed in menu.c: <snip> > > OR > > > sprintf(new_path, "PATH=%s\\bin;%s\\mingw\\bin;%s", > > - old_path, msys_path, msys_path); > > + msys_path, msys_path, old_path); > > I think the latter is correct Lode, thanks for the catch! Do you mind to leave it to me to commit? It's just a personal preference of keeping the number of commits "reasonable", even though Linus seems to prefer short commits. It's just three short commits in two days look like an overkill. On Jan 23, 5:31 pm, Johannes Sixt wrote: > On Wednesday 23 January 2008 02:11, Kirill wrote: > > - lstrcpynW((LPWSTR)name, tw, size); > > + lstrcpynW((LPWSTR)name, tw, strlen(text)); > This is not correct for two reasons... Wow! I'm burning in shame! That's way too stupid! I'm sorry. By the way, don't we want to also call mbstowcs two times, passing wcstr=NULL the first time, instead of allocating strlen+1 wchar_t? It'll be slower, but more logical/safer and we can do it only if Unicode string is requested. Moreover, we might want to keep two sets of strings in resources if we expect the number of menu items to grow. -- Kirill. P.S. Johannes and Johannes, please, accept my apologies if you find the following question offensive. Do you mind if one uses your signatures [instead of your names] when greeting you?
