Hi,

On Fri, 25 Jan 2008, Kirill wrote:

> On Jan 25, 2008 6:32 AM, Johannes Schindelin 
> <[EMAIL PROTECTED]> wrote:
>
> > On Thu, 24 Jan 2008, Kirill wrote:
> >
> > > In addition, the following two might be interesting as per 
> > > "Debugging with the Shell" on MSDN:
> > >
> > > [HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer]
> > > DesktopProcess= 1
> > >
> > > [HKEY_LOCAL_MACHINE\Software\Microsoft\Windows\CurrentVersion\Explorer\
> > >  AlwaysUnloadDll]
> >
> > Could you just implement that as a follow-up patch (and not put it 
> > into this commit message)?
>
> I've removed them from this commit message, but not sure how to add them 
> as a separate patch. The problem is they are useful only for developers 
> while debugging.

Exactly.  And as we are catering for developers ATM, that should be an 
important detail.  IIUC this patch would make 89383fe8(Add a simple script 
to kill and restart explorer and task manager) obsolete?  If it does, we 
might revert that commit, mentioning that your patch is the reason.

> You don't want to add them as part of the production installation. It 
> feels weird to have yet another pair of targets, e.g. ease-debugging and 
> ease-debugging-user (the AlwaysUnloadDll works in the user space as 
> well).

How about a new target "load":

load: load.reg
        regsvr32 -s $(TARGET)
        regedit -s $@

load.reg: install-user.reg WINREG=HKEY_CURRENT_USER\Software\Microsoft\Windows
        cp $< $@
        echo '' >> $@
        echo '[$(WINREG)\CurrentVersion\Explorer]' >> $@
        echo '"DesktopProcess"="1"' >> $@
        echo '' >> $@
        echo '[$(WINREG)\CurrentVersion\Explorer\AlwaysUnloadDll]' >> $@

And a similar one for "unload"?

Ciao,
Dscho

Reply via email to