Hi,
> -----Original Message-----
> From: Johannes Schindelin
> Sent: Saturday, February 09, 2008 8:38 AM
> On Fri, 8 Feb 2008, Kirill wrote:
> > diff --git a/exec.c b/exec.c
> > + if (!environment && msys_path()) {
> (I take it that you can use an environment NULL for a
> default, when there is no msys_path()?)
Yes, if the lpEnvironment argument of CreateProcess is NULL, it will use a
copy of the current environment. Just what we wanted.
> > diff --git a/menu.c b/menu.c
> > index c6a5a55..97811fa 100644
> > --- a/menu.c
> > +++ b/menu.c
> > @@ -123,8 +103,7 @@ static STDMETHODIMP invoke_command(void *p,
> > const char *wd;
> > DWORD dwAttr, fa;
> >
> > - adjust_path_for_git(msysPath);
> > - wsprintf(command, TEXT("wish.exe \"%s/bin/git-
> gui\""),
> > + wsprintf(command, TEXT("\"%s\\bin\\git.exe\" gui"),
>
> But does that not mean that we do not even have to adjust the PATH?
I actually thought about it. But the reason to keep adjusting the PATH is
what if git tries to find something that is not in the user's PATH? For the
Git installation it may not matter much because git and all it needs are in
the same folder (which semi-auto-magically made a part of the PATH). But for
developer installation, it could be more important because /bin and
/mingw/bin are both used. So, just to be on the safe side, I keep adjusting
path.
--
Kirill.
