On Mar 2, 2008, at 10:30 PM, Peter Harris wrote:

On Sat, Mar 1, 2008 Steffen Prohaska <[EMAIL PROTECTED]> wrote:

 Hi,
 I uploaded the installer Git-preview20080301.exe, which includes a
 recent master of official Git, includes git svn, and has
 core.autocrlf=true as its default.

I downloaded and installed this version of git, used it to clone
git://repo.or.cz/msysgit.git, rebuilt the installer, and wondered why
"git commit" was failing with errors about vi.

After some digging, it turns out that "vi" in msysgit.git is a shell
script, and git was trying to launch "sh\r" instead of "sh", since the
vi script was autocrlf'd.

You should force the msysgit repository to core.autocrlf = false (or
maybe core.autocrlf = input).  Even though msysgit runs on Windows it
is not a real cross-platform project.  MinGW emulates a Unix
environment and thus you should override core.autocrlf.


This patch fixes the problem.

I don't think this fix is needed.

                Steffen

Reply via email to