Re: [MTT devel] [MTT svn] svn:mtt-svn r1094 (for review)

[Josh Hursey]

Sorry it has taken me a while to get to this.

I think the patch is generally fine. I don't think it will hurt  
anything. I haven't tested it though, but I trust if you have then it  
should be fine. Let me know when it happens and I'll try to watch a  
bit more closely the nightly submits.

Thanks,
Josh

On Nov 1, 2007, at 3:34 PM, Ethan Mallove wrote:

Josh,

Before this gets committed to the live submit.php, can you
look at this? It should only effect the "environment" field.

Thanks,
Ethan


On Thu, Nov/01/2007 03:30:26PM, emall...@osl.iu.edu wrote:
Author: emallove
Date: 2007-11-01 15:30:26 EDT (Thu, 01 Nov 2007)
New Revision: 1094
URL: https://svn.open-mpi.org/trac/mtt/changeset/1094

Log:
 * "environment" field was not getting inserted due to
   a faulty `isset()` check
 * Added a second MTT DB admin


Text files modified:
   trunk/server/php/submit/index.php |    28 ++++++++++++++++++ 
+---------
   1 files changed, 19 insertions(+), 9 deletions(-)

Modified: trunk/server/php/submit/index.php
===================================================================== 
=========
--- trunk/server/php/submit/index.php   (original)
+++ trunk/server/php/submit/index.php	2007-11-01 15:30:26 EDT  
(Thu, 01 Nov 2007)
@@ -235,6 +235,9 @@

     for($i = 0; $i < $n; $i++) {

+        # The POST fields are enumerated starting at 1
+        $j = $i + 1;
+
         ########
         # Select/Insert: performance
         # Currently only support latency/bandwidth
@@ -363,7 +366,7 @@
         #########
         # Select/Insert: Environment
         $results_idxs_hash['environment_id'] = 0;
-        if( isset($_POST['environment']) ) {
+        if( isset($_POST["environment_$j"]) ) {
             $stmt_fields = array("environment");

             $stmt_values = array(get_scalar($param_set 
['environment'], $i) );
@@ -567,6 +570,9 @@
     }

     for($i = 0; $i < $n; $i++) {
+
+        # The POST fields are enumerated starting at 1
+        $j = $i + 1;

         ########
         # Select/Insert: test_build_compiler -> compiler
@@ -629,7 +635,8 @@
         #########
         # Select/Insert: Environment
         $results_idxs_hash['environment_id'] = 0;
-        if( isset($_POST['environment']) ) {
+
+        if( isset($_POST["environment_$j"]) ) {
             $stmt_fields = array("environment");

             $stmt_values = array(get_scalar($param_set 
['environment'], $i) );
@@ -1084,6 +1091,9 @@

     for($i = 0; $i < $n; $i++) {

+        # The POST fields are enumerated starting at 1
+        $j = $i + 1;
+
         ########
         # Select/Insert: compute_cluster
         $stmt_fields = array("platform_name",
@@ -1185,7 +1195,7 @@
         #########
         # Select/Insert: Environment
         $results_idxs_hash['environment_id'] = 0;
-        if( isset($_POST['environment']) ) {
+        if( isset($_POST["environment_$j"]) ) {
             $stmt_fields = array("environment");

             $stmt_values = array(get_scalar($param_set 
['environment'], $i) );
@@ -1767,8 +1777,8 @@

     $php_auth_user = $_SERVER['PHP_AUTH_USER'];
     $user          = $_POST['email'];
-#JJH    $admin         = 'ethan.mall...@sun.com';
-    $admin         = 'jjhur...@open-mpi.org';
+    $admin1        = 'jjhur...@open-mpi.org';
+    $admin2        = 'ethan.mall...@sun.com';
     $date          = date('r');
     $phpversion    = phpversion();
     $boundary      = md5(time());
@@ -1778,8 +1788,8 @@
     $attachment = chunk_split(base64_encode(file_get_contents 
($filename)));

     $headers = <<<END
-From: $admin
-Reply-To: $admin
+From: $admin1
+Reply-To: $admin1
 Date: $date
 X-Mailer: PHP v$phpversion
 MIME-Version: 1.0
@@ -1808,8 +1818,8 @@
     if (preg_match("/\w+@\w+/", $user, $m))
         mail($user, "MTT server error", $message, $headers);

-    # Email the MTT database administrator
-    mail($admin, "MTT server error (user: $php_auth_user)",  
$message, $headers);
+    # Email the MTT database administrator(s)
+    mail("$admin1, $admin2", "MTT server error (user:  
$php_auth_user)", $message, $headers);

     # Whack the temp file
     unlink($filename);
_______________________________________________
mtt-svn mailing list
mtt-...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/mtt-svn
_______________________________________________
mtt-devel mailing list
mtt-de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/mtt-devel