I like the "all" keyword. Are these no longer needed? &get_mpi_get_names() &get_mpi_install_names() &get_test_get_names() &get_test_build_names()
-Ethan On Fri, Apr/04/2008 03:31:07PM, jsquy...@osl.iu.edu wrote: > Author: jsquyres > Date: 2008-04-04 15:31:07 EDT (Fri, 04 Apr 2008) > New Revision: 1176 > URL: https://svn.open-mpi.org/trac/mtt/changeset/1176 > > Log: > Allow "all" keyword in mpi_get, test_get, and test_build fields. > > Text files modified: > trunk/CHANGES | 5 +++++ > > trunk/lib/MTT/MPI/Install.pm | 9 ++++++--- > > trunk/lib/MTT/Test/Build.pm | 9 ++++++--- > > trunk/lib/MTT/Test/Run.pm | 6 ++++-- > > 4 files changed, 21 insertions(+), 8 deletions(-) > > Modified: trunk/CHANGES > ============================================================================== > --- trunk/CHANGES (original) > +++ trunk/CHANGES 2008-04-04 15:31:07 EDT (Fri, 04 Apr 2008) > @@ -50,6 +50,11 @@ > - &mpi_details() - pass arbitrary values from test run sections > to the mpi details section, indexed by string > > +- Allow mpi_get_name, test_get_name, and test_build_name fields to > + accept the special value "all", meaning that they'll use all > + corresponding sections that are found (vs. needing to list every > + section explicitly) > + > - Added export for MTT_TEST_EXECUTABLE, may be used for clean up after > mpi process : pkill -9 $MTT_TEST_EXECUTABLE > > > Modified: trunk/lib/MTT/MPI/Install.pm > ============================================================================== > --- trunk/lib/MTT/MPI/Install.pm (original) > +++ trunk/lib/MTT/MPI/Install.pm 2008-04-04 15:31:07 EDT (Fri, 04 Apr > 2008) > @@ -199,7 +199,8 @@ > > # This is only warning about the INI file; we'll see > # if we find meta data for the MPI get later > - if (!$ini_full->SectionExists("mpi get: $mpi_get_name")) { > + if ($mpi_get_name ne "all" && > + !$ini_full->SectionExists("mpi get: $mpi_get_name")) { > Warning("Warning: MPI Get section \"$mpi_get_name\" does > not seem to exist in the INI file\n"); > } > > @@ -207,7 +208,8 @@ > # skip it. Don't issue a warning because command line > # parameters may well have dictated to skip this MPI > # get section. > - if (!exists($MTT::MPI::sources->{$mpi_get_name})) { > + if ($mpi_get_name ne "all" && > + !exists($MTT::MPI::sources->{$mpi_get_name})) { > Debug("Have no sources for MPI Get \"$mpi_get_name\", > skipping\n"); > next; > } > @@ -217,7 +219,8 @@ > > # For each MPI source > foreach my $mpi_get_key (keys(%{$MTT::MPI::sources})) { > - if ($mpi_get_key eq $mpi_get_name) { > + if ($mpi_get_name eq "all" || > + $mpi_get_key eq $mpi_get_name) { > > # For each version of that source > my $mpi_get = $MTT::MPI::sources->{$mpi_get_key}; > > Modified: trunk/lib/MTT/Test/Build.pm > ============================================================================== > --- trunk/lib/MTT/Test/Build.pm (original) > +++ trunk/lib/MTT/Test/Build.pm 2008-04-04 15:31:07 EDT (Fri, 04 Apr > 2008) > @@ -120,7 +120,8 @@ > > # This is only warning about the INI file; we'll see > # if we find meta data for the test get later > - if (!$ini_full->SectionExists("test get: $test_get_name")) { > + if ($test_get_name ne "all" && > + !$ini_full->SectionExists("test get: $test_get_name")) { > Warning("Test Get section \"$test_get_name\" does not > seem to exist in the INI file\n"); > } > > @@ -128,14 +129,16 @@ > # skip it. Don't issue a warning because command line > # parameters may well have dictated to skip this > # section. > - if (!exists($MTT::Test::sources->{$test_get_name})) { > + if ($test_get_name ne "all" && > + !exists($MTT::Test::sources->{$test_get_name})) { > Debug("Have no sources for Test Get \"$test_get_name\", > skipping\n"); > next; > } > > # Find the matching test source > foreach my $test_get_key (keys(%{$MTT::Test::sources})) { > - if ($test_get_key eq $test_get_name) { > + if ($test_get_name eq "all" || > + $test_get_key eq $test_get_name) { > my $test_get = $MTT::Test::sources->{$test_get_key}; > > # For each MPI source > > Modified: trunk/lib/MTT/Test/Run.pm > ============================================================================== > --- trunk/lib/MTT/Test/Run.pm (original) > +++ trunk/lib/MTT/Test/Run.pm 2008-04-04 15:31:07 EDT (Fri, 04 Apr 2008) > @@ -105,7 +105,8 @@ > > # This is only warning about the INI file; we'll see > # if we find meta data for the test build later > - if (!$ini_full->SectionExists("test build: > $test_build_name")) { > + if ($test_build_name ne "all" && > + !$ini_full->SectionExists("test build: > $test_build_name")) { > Warning("Test Build section \"$test_build_name\" does > not seem to exist in the INI file\n"); > } > > @@ -130,7 +131,8 @@ > last > if (MTT::Util::find_terminate_file()); > > - if ($test_build_key eq $test_build_name) { > + if ($test_build_name eq "all" || > + $test_build_key eq $test_build_name) { > my $test_build = > $MTT::Test::builds->{$mpi_get_key}->{$mpi_version_key}->{$mpi_install_key}->{$test_build_key}; > Debug("Found a match! $test_build_key > [$simple_section\n"); > if (!$test_build->{test_result}) { > _______________________________________________ > mtt-svn mailing list > mtt-...@open-mpi.org > http://www.open-mpi.org/mailman/listinfo.cgi/mtt-svn
