Hi Jeff,
I'm not sure about this. From what's written in the comment, restoring
%ENV is only for a 'make check' step, but we don't have such step for
cmake. That's why I skipped it.
I mention it because you're modifying LD_LIBRARY_PATH above -- so you
should restore it when you're done.
Aha, yes, you're right. The portion of modifying LD_LIBRARY_PATH should
also be removed.
Gotcha. So if our Cmake system is only targeted at windows, then I
think OMPI.pm can make the determination automatically to call the
GNU_Install or Cmake version.
Perhaps the _do_step stuff should be factored out into a separate .pm
so that you don't have to duplicate all that code between
GNU_Install.pm and Cmake.pm...?
Yes, that might be the easiest and best solution so far. :-)
Thanks,
Shiqing
