On Mar 17, 2011, at 12:49 PM, Abhishek Kulkarni wrote:

> They are the detailed reports of each stage. More specifically, they are all 
> the files $phase-$section-$mpi_name-$mpi_version.txt generated in $SCRATCH. 
> If you meant where does @attachments come from in the code:
> 
> +            my @reports = _get_report_filenames($results_arr);
> +            Verbose(">> Sending detailed reports: @reports\n");
> +            MTT::Mail::Send($subject, $to, $from, $body . $body_footer, 
> @reports);

Ah -- there it is.  I missed that in the patch.

Patch looks good to me!

> @reports is where @attachments come from.
> 
> I extended the interface of Mail::Send such that it takes an optional 
> @attachments parameter. If there are attachments it uses MIME::Lite otherwise 
> it resorts to the existing approach of opening a pipe to the mail agent.
> 
> Abhishek
> 
> On Thu, Mar 17, 2011 at 10:14 AM, Jeff Squyres <jsquy...@cisco.com> wrote:
> Where do the @attachments come from?
> 
> 
> On Mar 10, 2011, at 7:20 PM, Abhishek Kulkarni wrote:
> 
> > Hello,
> >
> > While working towards setting up MTT to test the CIFTS FTB middleware, we 
> > resorted to a TextFile + Email reporter; largely because i) the frequency 
> > of testing is low ii) lesser number of tests and iii) we did not want to 
> > deal with setting up a centralized infrastructure to host the test results.
> >
> > The reporter worked great for us except that we wanted a little more than 
> > just the summary. The attached patch adds a new boolean flag 
> > "email_detailed_reports" which sends out the detailed reports of each phase 
> > as attachments. I have had to use two files from CPAN to encode the email 
> > as a multipart message. Right now only the *.txt files are attached but it 
> > could also be extend to send an HTML-formatted email with HTML attachments.
> >
> > Do you think it looks okay to go in?
> >
> > Thanks,
> > Abhishek
> > <mime.patch>_______________________________________________
> > mtt-devel mailing list
> > mtt-de...@open-mpi.org
> > http://www.open-mpi.org/mailman/listinfo.cgi/mtt-devel
> 
> 
> --
> Jeff Squyres
> jsquy...@cisco.com
> For corporate legal information go to:
> http://www.cisco.com/web/about/doing_business/legal/cri/
> 
> 
> _______________________________________________
> mtt-devel mailing list
> mtt-de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/mtt-devel
> 
> _______________________________________________
> mtt-devel mailing list
> mtt-de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/mtt-devel


-- 
Jeff Squyres
jsquy...@cisco.com
For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/


Reply via email to