There is a bit of a dichotomy with the way that exit directions are treated but in the long term I think we may have to split exit directions into two groups, the "normal" exits which we can represent with a (short unsigned) numeric constant internally and "special" exits with a "string" representation. We then can allow the user to specify what they want Mudlet to send to the MUD server for those "normal" exits - which will pay dividends for internationalisation if we ever embrace it.
Coding the normal exits with numbers will make the code more compact and reliable as we can then loop through all the values rather than having to repeat code blocks once for each distinct direction. The cost is that various QMap elements in the TRoom class will be split into <int, ???> ones for normal exits and <QString, ???> for the special exits and some code will have to check both. During a migration though, any "normal" exit in existing map data/code that is not in the matching form for the defined value for that direction should end up in the "special" areas and not be lost so that the user can correct it. -- You received this bug notification because you are a member of Mudlet Makers, which is subscribed to Mudlet. https://bugs.launchpad.net/bugs/1114594 Title: setExit, setExitStub, queryRoomExits - fix inconsistency in direction parameters and returned names Status in Mudlet the MUD client: Fix Committed Bug description: setExit() accepts a number or a short direction name (like "e", "ne") setExitStub() accepts a number as direction getRoomExits() returns a long direction name (like "east", "north") connectExitStub() is even more bizarre, it does not work with 2 arguments as stated in manual as well setDoor() and getDoors() requires and returns direction in short form ("e", "ne") Also writing scripts for non-english mud is painful as I have to maintain 3 name mappings just for directions... translating in one or another way. speedwalk also outputs short directions and I have to translate them into correct ones (and why up and down was not shortened as well?). Is it possible to make it consistent and more friendly? Make it all english short names for example or numbers everywhere (less friendly IMHO)? Mudlet: 2.1 To manage notifications about this bug go to: https://bugs.launchpad.net/mudlet/+bug/1114594/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mudlet-makers Post to : [email protected] Unsubscribe : https://launchpad.net/~mudlet-makers More help : https://help.launchpad.net/ListHelp
