Investigating the provided file I find that ALL the rooms are in the -1
default area. The highest areaID used is 91 but all of them from 1 to
91 are empty.. This is not the problem.
It seems that the twp sample rooms and I think from some debug code that
I added to test things that ALL the rooms are "Locked". Locked rooms
are NOT put into the boost::graph data structure so they are not
considered for speedwalks. The current code, although it checks for a
usable exit from the starting room and bails out if there isn't one does
NOT check that the DESTINATION room is unlocked.
The simple one line fix to prevent this crash is, in pseudo-diff form,
in the TMap class file, at around line 836:
bool TMap::findPath( int from, int to )
{
if( mMapGraphNeedsUpdate )
{
initGraph();
}
TRoom * pFrom = mpRoomDB->getRoom( from );
TRoom * pTo = mpRoomDB->getRoom( to );
- if( !pFrom || !pTo )
+ if( !pFrom || !pTo || pTo->isLocked )
{
return false;
}
... other stuff ...
}
We do need to revise the documentation slightly I think because I feel,
in nit-picking, theoretic detail, it should be possible to start a route
finding/speedwalk FROM a LOCKED room (a locked room is equivalent to an
infinite room weighting but the room weighting is used as the cost TO
ENTER a room, unless overridden by the weighting of the exit leading TO
it) but in practice this would be quite tricky to code for because the
room will not be included in the compiled BGL graph structure as stated
above.
I will raise a PR and patch the above fix (and clean up a couple of
other related locked room issue:)
* delete the unregistered TLuaInterpreter::isLockedRoom() function which
is not available to users and is a duplicate of the
TLuaInterpreter::lroomLocked() function that is made available!
* provide a mapper GUI context command "unlock" to reverse the "lock"
command - so that a user can select a group of rooms and be able to
unlock them for use in speedwalks as they can't do at the moment if they
lock a wrong room.
--
You received this bug notification because you are a member of Mudlet
Makers, which is subscribed to Mudlet.
https://bugs.launchpad.net/bugs/1263447
Title:
Crash on pathfinding using unconnected maps
Status in Mudlet:
Confirmed
Bug description:
Import the sample map with rooms 1,2 which area in area 1 and are not
connected. Then try to do getPath(1,2) - a crash happens.
This happens on Mudlet 2.1, Chris7/Mudlet2/mudletDev and SF master.
mudletDev backtrace:
0 astar_search<boost::adjacency_list<boost::listS, boost::vecS,
boost::directedS, boost::no_property, boost::property<boost::edge_weight_t,
float> >, distance_heuristic<boost::adjacency_list<boost::listS, boost::vecS,
boost::directedS, boost::no_property, boost::property<boost::edge_weight_t,
float> >, float, std::vector<location> >, astar_goal_visitor<unsigned long>,
unsigned long*, boost::shared_array_property_map<float,
boost::vec_adj_list_vertex_id_map<boost::no_property, unsigned long> >, float*,
boost::adj_list_edge_property_map<boost::directed_tag, float, float const&,
unsigned long, boost::property<boost::edge_weight_t, float> const,
boost::edge_weight_t>, boost::vec_adj_list_vertex_id_map<boost::no_property,
unsigned long>, boost::shared_array_property_map<boost::default_color_type,
boost::vec_adj_list_vertex_id_map<boost::no_property, unsigned long> >,
std::less<float>, boost::closed_plus<float>, float, float> astar_search.hpp
294 0x5f5b4a
1 boost::astar_search<boost::adjacency_list<boost::listS, boost::vecS,
boost::directedS, boost::no_property, boost::property<boost::edge_weight_t,
float, boost::no_property>, boost::no_property, boost::listS>,
distance_heuristic<boost::adjacency_list<boost::listS, boost::vecS,
boost::directedS, boost::no_property, boost::property<boost::edge_weight_t,
float, boost::no_property>, boost::no_property, boost::listS>, float,
std::vector<location, std::allocator<location> > >, astar_goal_visitor<unsigned
long>, boost::graph_visitor_t, boost::bgl_named_params<float*,
boost::vertex_distance_t, boost::bgl_named_params<unsigned long*,
boost::vertex_predecessor_t, boost::no_property> > > astar_search.hpp
329 0x5f5b4a
2 TMap::findPath TMap.cpp 771 0x5ef6f3
3 TLuaInterpreter::getPath TLuaInterpreter.cpp 4221 0x4de665
4 ?? /usr/lib/x86_64-linux-gnu/liblua5.1.so.0
0x7ffff797c23c
5 ?? /usr/lib/x86_64-linux-gnu/liblua5.1.so.0
0x7ffff7986c7b
6 ?? /usr/lib/x86_64-linux-gnu/liblua5.1.so.0
0x7ffff797c64d
7 ?? /usr/lib/x86_64-linux-gnu/liblua5.1.so.0
0x7ffff797b8d7
8 ?? /usr/lib/x86_64-linux-gnu/liblua5.1.so.0
0x7ffff797c802
9 lua_pcall /usr/lib/x86_64-linux-gnu/liblua5.1.so.0
0x7ffff7978361
10 TLuaInterpreter::call TLuaInterpreter.cpp 10178 0x4ef23d
11 TAlias::execute TAlias.cpp 426 0x529368
12 TAlias::match TAlias.cpp 275 0x52a553
13 TAlias::match TAlias.cpp 284 0x529bfe
14 AliasUnit::processDataStream AliasUnit.cpp 281 0x537754
15 Host::send Host.cpp 638 0x45ca9c
16 TCommandLine::enterCommand TCommandLine.cpp 522 0x51dd5c
17 TCommandLine::event TCommandLine.cpp 236 0x51f413
18 QApplicationPrivate::notify_helper(QObject*, QEvent*)
/home/vadi/Programs/Qt5.2.0/5.2.0/gcc_64/lib/libQt5Widgets.so.5
0x7ffff644ef34
19 QApplication::notify(QObject*, QEvent*)
/home/vadi/Programs/Qt5.2.0/5.2.0/gcc_64/lib/libQt5Widgets.so.5
0x7ffff6452cfe
20 QCoreApplication::notifyInternal(QObject*, QEvent*)
/home/vadi/Programs/Qt5.2.0/5.2.0/gcc_64/lib/libQt5Core.so.5
0x7ffff54eb554
... <More>
master backtrace:
0 put<float, float> property_map.hpp 176 0x5f14e5
1 astar_search<boost::adjacency_list<boost::listS, boost::vecS,
boost::directedS, boost::no_property, boost::property<boost::edge_weight_t,
float> >, distance_heuristic<boost::adjacency_list<boost::listS, boost::vecS,
boost::directedS, boost::no_property, boost::property<boost::edge_weight_t,
float> >, float, std::vector<location> >, astar_goal_visitor<unsigned long>,
unsigned long*, boost::shared_array_property_map<float,
boost::vec_adj_list_vertex_id_map<boost::no_property, unsigned long> >, float*,
boost::adj_list_edge_property_map<boost::directed_tag, float, float const&,
unsigned long, boost::property<boost::edge_weight_t, float> const,
boost::edge_weight_t>, boost::vec_adj_list_vertex_id_map<boost::no_property,
unsigned long>, boost::shared_array_property_map<boost::default_color_type,
boost::vec_adj_list_vertex_id_map<boost::no_property, unsigned long> >,
std::less<float>, boost::closed_plus<float>, float, float> astar_search.hpp
294 0x5f14e5
2 boost::astar_search<boost::adjacency_list<boost::listS, boost::vecS,
boost::directedS, boost::no_property, boost::property<boost::edge_weight_t,
float, boost::no_property>, boost::no_property, boost::listS>,
distance_heuristic<boost::adjacency_list<boost::listS, boost::vecS,
boost::directedS, boost::no_property, boost::property<boost::edge_weight_t,
float, boost::no_property>, boost::no_property, boost::listS>, float,
std::vector<location, std::allocator<location> > >, astar_goal_visitor<unsigned
long>, boost::graph_visitor_t, boost::bgl_named_params<float*,
boost::vertex_distance_t, boost::bgl_named_params<unsigned long*,
boost::vertex_predecessor_t, boost::no_property> > > astar_search.hpp
329 0x5f14e5
3 TMap::findPath TMap.cpp 751 0x5eb0bd
4 TLuaInterpreter::getPath TLuaInterpreter.cpp 4133
0x4daee7
5 ?? /usr/lib/x86_64-linux-gnu/liblua5.1.so.0
0x7ffff797c23c
6 ?? /usr/lib/x86_64-linux-gnu/liblua5.1.so.0
0x7ffff7986c7b
7 ?? /usr/lib/x86_64-linux-gnu/liblua5.1.so.0
0x7ffff797c64d
8 ?? /usr/lib/x86_64-linux-gnu/liblua5.1.so.0
0x7ffff797b8d7
9 ?? /usr/lib/x86_64-linux-gnu/liblua5.1.so.0
0x7ffff797c802
10 lua_pcall /usr/lib/x86_64-linux-gnu/liblua5.1.so.0
0x7ffff7978361
11 TLuaInterpreter::call TLuaInterpreter.cpp 10111 0x4eae3d
12 TAlias::execute TAlias.cpp 426 0x5250b8
13 TAlias::match TAlias.cpp 275 0x5262a3
14 TAlias::match TAlias.cpp 284 0x52594e
15 AliasUnit::processDataStream AliasUnit.cpp 281 0x5334a4
16 Host::send Host.cpp 636 0x45c65c
17 TCommandLine::enterCommand TCommandLine.cpp 522
0x519aac
18 TCommandLine::event TCommandLine.cpp 236 0x51b163
19 QApplicationPrivate::notify_helper(QObject*, QEvent*)
/home/vadi/Programs/Qt5.2.0/5.2.0/gcc_64/lib/libQt5Widgets.so.5
0x7ffff644ef34
20 QApplication::notify(QObject*, QEvent*)
/home/vadi/Programs/Qt5.2.0/5.2.0/gcc_64/lib/libQt5Widgets.so.5
0x7ffff6452cfe
... <More>
To manage notifications about this bug go to:
https://bugs.launchpad.net/mudlet/+bug/1263447/+subscriptions
_______________________________________________
Mailing list: https://launchpad.net/~mudlet-makers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~mudlet-makers
More help : https://help.launchpad.net/ListHelp
