This is awesome. Rather than MMV depending on MobileFrontend, if we want to make this work on mobile I imagine a better thing to do would be to make it dependent on Extension:Mantle [1] since Mantle currently provides the templates that this would need and is a much more lightweight extension to add as a dependency.
This could be a great opportunity to move Overlay.js from MobileFrontend to extension Mantle and try and begin consolidating MediaViewer, MobileFrontend, VE and Flow's Overlay/Modal JS and css code here. We already successfully began porting MobileFrontend's class system to OOJS so this would give us an opportunity to reduce some of MediaWiki's code debt relating to overlays and move closer to a unified OOUI modal/overlay thing. I'd be interested in looking at how OOUI's Modals and MobileFrontend's Overlay differ. This is what I'd do personally, but I'd be interested in other opinions. I can help out with code review and moving this along as this sounds great! :-) See also [Tracking] Consolidate code for MediaViewer across desktop and mobile [2] [1] https://www.mediawiki.org/wiki/Extension:Mantle [2] https://bugzilla.wikimedia.org/show_bug.cgi?id=63504 On Mon, Oct 13, 2014 at 2:32 PM, Brion Vibber <[email protected]> wrote: > I've gotten some great review feedback from Gilles on the desktop-web > integration of my ogv.js JavaScript & Flash compatibility layers for Ogg > Theora/Vorbis media files -- thanks Gilles! > > * libraries: https://gerrit.wikimedia.org/r/#/c/165477/ > * desktop integration: https://gerrit.wikimedia.org/r/#/c/165478/ > > These are getting pretty close to ready to land, I think. > > > I would love to get some review on the mobile overlay I've whipped up as > well. This supports both native WebM playback (Android Chrome, Android > Firefox, Firefox OS) and ogv.js playback (iOS 7/8 Safari). > > * mobile overlay: https://gerrit.wikimedia.org/r/#/c/165479/ > * Live demo: https://ogvjs-testing.wmflabs.org/ > > > A few open questions: > > 1) Is this the right way to do mobile overlay code? (It's basically a rip of > the existing photo viewer overlay in MobileFrontend, but lives in > TimedMediaHandler.) Is the overlay interface stable enough for other > extensions to use it for mobile-specific features? (I had to make updates > for object-model and template things that changed since this summer.) > > 2) Is the inline icon too huge/ugly here for audio files? Should it be > arranged differently, or display the player inline instead of as an overlay > for audio? > > 3) Should more controls be added to the overlay's bottom toolbar, such as > manual resolution selection or an 'Open in VLC' link to support HD playback > on iOS? > > 4) Should we autoplay when opening the overlay, or require a second tap? > > 5) How should we handle devices with no native playback that are either too > slow (iOS 6 Safari) or lack necessary features needed for the player > (Windows Phone)? > > > Current known bugs in the mobile overlay: > > * CPU speed check not yet integrated to force to lowest resolution for old > iPhones/iPads (this exists on the desktop integration, just needs to be > moved to common code) > > * autoplay doesn't seem to work with native playback right now > > -- brion > > _______________________________________________ > Mobile-l mailing list > [email protected] > https://lists.wikimedia.org/mailman/listinfo/mobile-l > _______________________________________________ Multimedia mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/multimedia
