Moin,
a small patch for the src-folder:
A few warnings deleted, headerfiles included, unused variables removed.
A few major bugs fixed:
syncengine.c line 354: The ',' looks like a typo, I assume '&&' is the correct.
Otherwise the comment for the function is plainly wrong.
syncengine.c line 447: gpointer sync_main(gpointer data) doesn't return a
value. It looks to me that sync_main is only used to create the
threads, and the return-value is never evaluated (I might be wrong
here, please correct me if so), therefore I added a 'return NULL' at
the end of the function. I'm not content with that return-value,
because it is used as return in an error-case in this function, too,
but I'm not sure what makes the most sense to return.
sync_vtype.c line 314 and 536: parentheses added to make parsing of && and ||
clear for the compiler. Please review if the behaviour is now the
intended one. My tests say so, but I might be wrong :)
sync_vtype.c line 216: alarmaction might be used without initialization. I
heavily changed the order of the code and the if-clauses in the
function, please have a close look at it.
The function sync_vtype_convert() is way too big in my eyes, but that's
another story :)
gui.c line 1325: parentheses problem if you use '&'. I'm not quite sure here,
but the '&' should be '&&', shouldn't they? I changed both [ok, now the
parentheses aren't needed, but for readability...]}
callback.s line 39: gboolean on_syncpairwin_delete_event has no return value. I
think changing the return-value to 'void' should have make no troubles
Well, that doesn't fix all the warnings during compilation - but most of them.
Patches are us usual against the cvs-version.
It's running on my test-machine, but I can't test some of the plugins
currently, so please review for any sideeffects in the plugins.
ciao,
Stefan
--
Stefan Behlert
-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click
_______________________________________________
Multisync-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/multisync-devel
