On Mon, 2004-11-08 at 14:01 -0500, Ove Kaaven wrote:
> While trying to sync my Ericsson T68 (using IrMC) with Evolution 2, it
> crashed. I tracked the problem down to a null object pointer, which I
> could work around with
>
> Index: evolution_sync.c
> ===================================================================
> RCS file:
> /cvsroot/multisync/multisync/plugins/evolution2_sync/src/evolution_sync.c,v
> retrieving revision 1.2.2.10
> diff -u -r1.2.2.10 evolution_sync.c
> --- evolution_sync.c 27 Oct 2004 20:14:04 -0000 1.2.2.10
> +++ evolution_sync.c 8 Nov 2004 18:56:20 -0000
> @@ -272,7 +272,7 @@
> {
> GError *error = NULL;
> evo_debug(env, 2, "start: syncobj_modify");
> - evo_print_binary(object, strlen(object) + 1);
> + evo_print_binary(object, object ? (strlen(object) + 1) : 0);
>
> switch (objtype) {
> case SYNC_OBJECT_TYPE_PHONEBOOK:
>
> but even after doing this, the sync appeared to fail and the changes
> that appeared to cause the crash appear lost. Any changes I do from now
> on probably work though. I'm not sure what could cause object to be
> null, it seems to me IrMC may do this if it fails to get a change entry
> or the entry has a length of null or whatever. But I hope this helps you
> fix this crash whenever it does happen.
>
jupp. this line actually should have been removed. but it still is a
error since the evo2 plugin gets a change without data and with uid. so
there is definetly a bug in the irmc side.
To be able to at least sync somewhat add this to the syncobj_modify
function at the start:
if (!object && !uid) {
sync_set_pair_status(env->handle, "No data to modify");
sync_set_requestfailed(env->handle);
return;
}
I will try to look into this some time (i have access to a S65)
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by:
> Sybase ASE Linux Express Edition - download now for FREE
> LinuxWorld Reader's Choice Award Winner for best database on Linux.
> http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click
> _______________________________________________
> Multisync-devel mailing list
> [EMAIL PROTECTED]
> https://lists.sourceforge.net/lists/listinfo/multisync-devel
--
Armin Bauer <[EMAIL PROTECTED]>
-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click
_______________________________________________
Multisync-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/multisync-devel
