On Fri, Aug 27, 2004 at 03:02:29PM -0700, Peter Williams wrote: > Few patch feedback notes, from an XP Pro platform build, using ms/do_ms > with cl (12.000.8804)compiler.
Thanks for the feedback. I've made an updated patch available at: http://www.scs.carleton.ca/~mgold/patches/openssl-add-mcard-2.patch I no longer have access to any smart cards, so I haven't been able to test it. > 1. patch contains a diff of engine/crypto/Makefile. No such file exists in > tarball. (Post ms/do_ms, no such file exists, also.) It's in the tarball, but it's just a link to Makefile.ssl. I've removed it from the diff. > 2. running ms\do_ms indicated "Warning: ENGINE_load_musclecard does not > have a number assigned" a few times. I assigned it a number in util/libeay.num. > 3. compile of source using cl went fine until compiling > crypto/engine/hw_musclecard.c. > - had to alter vendor_defs of musclecard.h to import musclecard.h from std > windows install path for muscle libraries, rather than <PCSC/...> That #include statement shouldn't have been there, since it will prevent OpenSSL from building on machines where PCSC isn't installed. I copied the necessary structs/defines directly into vendor_defns/musclecard.h. The structs are slightly modified; I replaced some pointers to other structs with void pointers, but I don't think that makes a difference. It's just so I don't have to include every struct they depend on. > - had to remove -WX compiler option, to allow some downcast warnings to be > ignored. Can you post a few examples? I don't have access to a Windows machine, and GCC doesn't print any warnings. - Michael
signature.asc
Description: Digital signature
_______________________________________________ Muscle mailing list [EMAIL PROTECTED] http://lists.drizzle.com/mailman/listinfo/muscle
