Hello!

We fully agree with what Martin Paljak pointed out in his last mail!

The SCARD_CTL_CODE macro should be in pcsc-lite headers in order to ensure
a consistent control code generation across all driver that need to
implement in the future.
Furthermore it is convenient to also have the definition of the
SCARD_CTL_CODE(3400)code there because this control code shoudl be
implemented by all drivers following the spec in order to find out what
control codes are supported. All other control codes either have not to be
implemented by all drivers or are some kind of vendor specific again; as a
result these should be placed inside the driver projects and the software
which makes use of the control codes and is vendor specific too..
This is also why we sayed that the tag numbers defined in the teletrust
spec which Martin also added to pcsc-lite headers is a nice-to-have but not
essential!

Regarding the reader.h file:
I am not sure how you want to use this FEATURE definitions! Could you
please explain in more detail!?
The teletrust spec wants the application (which in fact is a PKCS#11 module
or other - vendor specific - software which makes use of the driver/device
features) to get a list of supported control codes by issuing the
SCARD_CTL_CODE(3400), for the usage of all further control codes the driver
and the application have to share a header file with the control codes
defined, pcsclite should not be bothered with this.
Adding an additional FEATURE request may be more complicated than useful!
We appreciate a solution which is as well convenient as as most standard
conform as possible, vendor specific features should be kept seperated in
order to ensure a clean pcsclite implementation.

--
Best regards,
Markus Hofer

OMNIKEY GmbH
Ferihumerstrasse 13
A-4040 Linz
Austria

Tel       +43 (0) 732 / 602220  - 30
Mobile    +43 (0) 664 / 1106386
Fax       +43 (0) 732 / 602220  - 15
E-Mail    [EMAIL PROTECTED]
Web       www.omnikey.com



                                                                           
             Martin Paljak                                                 
             <[EMAIL PROTECTED]                                             
             ail.com>                                                   An 
             Gesendet von:              [EMAIL PROTECTED], MUSCLE   
             [EMAIL PROTECTED]          <[email protected]>      
             sts.musclecard.co                                       Kopie 
             m                                                             
                                                                     Thema 
                                        Re: Re: [Muscle] SCARD_CTL_CODE    
             14.03.2005 13:59           macro introduction                 
                                                                           
                                                                           
              Bitte antworten                                              
                    an                                                     
               Martin Paljak                                               
             <[EMAIL PROTECTED]                                             
              ail.com>; Bitte                                              
               antworten an                                                
                  MUSCLE                                                   
             <[EMAIL PROTECTED]                                             
               clecard.com>                                                
                                                                           
                                                                           




On Mon, 14 Mar 2005 13:49:27 +0100, Ludovic Rousseau
<[EMAIL PROTECTED]> wrote:
> I do not want to do _only_ the first step. Martin proposed two patches
> in [1] and [2] but they have some problems:
Please note that those are somewhat out of date (may have been) I
updated them with the patches i sent to the mailing list today
morning.
> - the #define should be in a pcsc-lite header file and not in a reader
> header file since they will be used by the applications
The only define that teletrust implementation defines and what relates
to pcsc directly is SCARD_CTL_CODE. The IFDHandler must match only one
control code (that would depend on SCARD_CTL_CODE) and that is
SCARD_CTL_CODE(3400). What will be the value of the result of this
macro is not relevant as long as both the application and ifdhandler
agree on the value.
> - since I don't know which constant names YOU (smart card reader
> manufacturers:  Omnikey, Gemplus, SCM, Kobil, etc) use, so I bet the
> list is not complete.
Everything else is actually application side - IFDHandler answers with
actual ioctl codes as it implements them, and thus must be used by the
application as they are returned. Internal implementation might or
might not depend on things exported by pcsc-lite (Like reuse the
SCARD_CTL_CODE as it is done in the patch against ccid)

What is application specific and does not concern to pcsc at all are
the tag numbers defined in the teletrust spec and also included to
pcsclite.h just for completeness (i guess it will be in the pcsc 2.0
headers sometimes). They might be in an application specific header
file (a la pkcs11 headers are usually distributed with applications
making use of pkcs11) but  it is handy to have the definitions in the
pcsc-lite headers.

> So I repeat my question: what names (and for what purpose) do you
> want/need to be defined? You can cut and paste a windows header file
> (this is the preferred method).

The only thing that is missing in pcsc-lite and what is needed is
SCARD_CTL_CODE.

Everything else is either derived from this or is not relevant AFAIK.

--
Martin Paljak
[EMAIL PROTECTED]
http://martin.paljak.pri.ee/
+372.5156495 - phone
_______________________________________________
Muscle mailing list
[email protected]
http://lists.drizzle.com/mailman/listinfo/muscle


_______________________________________________
Muscle mailing list
[email protected]
http://lists.drizzle.com/mailman/listinfo/muscle

Reply via email to