On 25/07/05, Martin Leung <[EMAIL PROTECTED]> wrote: > Hi, Hello,
> Below are a few more minor patches: > > 1. x_slot_no_duplicate_enum.diff > - avoid re-examine of session object everytime a match is found Rejected. Your patch may have side effects. > 2. x_slot_mech.diff > - I think mechanism info shall include only flags that supported by > the token. In particular, the CKF_WRAP flag caused some previous > versions of Mozilla Suite failed on keygen as Mozilla try to > use the token to do a key wrapping that is unsupported. Rehected. Maybe a better solution is to ask the device the actual list of supported mechanisms? > 3. x_session_free.diff > - simplified the code a bit. Rejected. I don't see why this simplification is needed. It may also be an over simplification with bad side effects. > 4. x_object_write_key_attrib.diff > - token may interest in some properties introduced by the caller > of the pkcs11 module. The additional code gives chance to the token > to examine the key template attributes. Rejected. Show me a use case first or ask the code author to bless your patch. > 5. x_object_more_logAttr.diff > - added lookup of a few attributes used by Mozilla Accepted > 6. crypt_datalen.diff > - I think error should be raised if datalen > keysize Rejected. Demonstrate the bug first. I would like to be very conservative regarding source code change. Your patches should be either trivial to understand or include the demonstration of a real bug or get the blessing of the original code author. Thanks, -- Dr. Ludovic Rousseau For private mail use [EMAIL PROTECTED] and not "big brother" Google _______________________________________________ Muscle mailing list [email protected] http://lists.drizzle.com/mailman/listinfo/muscle
