Hi, The code from SVN does not compile because of a minor typo (PCSC_SCF_Initialized instead of PCSC_Initialized in PCSC_SCF_Initialize(void)), with this fixed, the code compiles and works on Solaris 8.
-Najam. -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Ludovic Rousseau Sent: Monday, October 17, 2005 8:23 AM To: MUSCLE Subject: Re: [Muscle] Patch for PCSC shim for Solaris SCF (winscard_scf.c) On 05/10/05, Najam Siddiqui <[EMAIL PROTECTED]> wrote: > Hi, Hello, > The patch addresses the following. > > 1. Fixes bug in SCardGetStatusChange where Context index was being used > instead of Reader index, it worked only when there was just one context. OK. patched. > 2. Adds cleanup code to SCardUnload. OK. patched. > 3. Changes isOCFServerRunning(.) because of memory leak issues in > libsmartcard.so on Solaris 8, everytime SCF_Session_getSession - > SCF_Session_close is called libsmartcard leaks memory. I don't think you patch is the correct solution. I would prefer to see the correction in libsmartcard.so. Patch rejected for now. > 4. Fix issue where SCardGetStatusChange returns incorrect status when it is > called right after SCardEstablishContext the first time after the > libpcsclite.so is loaded in memory, the fix is to make PCSC_Initialize() > wait till OCF has been initialized and the internal states are consistent. I do not understand why you do not just use: absTime.tv_sec = currTime.tv_sec + 2; absTime.tv_nsec = currTime.tv_usec*1000; to convert a struct timeval in a struct timespec. Applied Since I do not have a Solaris machine to test and because I changed your code a bit, the code may not even compile anymore. So please test the SVN version and tell me if it is OK or not. Thanks, -- Dr. Ludovic Rousseau For private mail use [EMAIL PROTECTED] and not "big brother" Google _______________________________________________ Muscle mailing list [email protected] http://lists.drizzle.com/mailman/listinfo/muscle _______________________________________________ Muscle mailing list [email protected] http://lists.drizzle.com/mailman/listinfo/muscle
