2010/2/12 Max Vozeler <[email protected]>: > [Just noticed this didn't make it to the list because I sent > from a non-subscribed address. Resending.] > > Hi Ludovic, > > On Mon, Feb 01, 2010 at 03:52:07PM +0100, Ludovic Rousseau wrote: >> Souldn't you test the buffer[ERROR_OFFSET] value to be sure you do not >> ignore valid error codes? > > Yep. Explicitly testing for HW_ERROR now. > >> In the case of BCM588. I suggest to just correct the >> buffer[ERROR_OFFSET] and buffer[STATUS_OFFSET] bytes. >> And wrap the code inside a #ifdef BOGUS_BROADCOM_FIRMWARE like for the >> other BOGUS_* patches. > > See below. I also made it log the values of both STATUS > and ERROR register before correcting them to give a clear > trace of their previous values. > > Anyone here who has a BCM588x and would be willing to > test the change? Unfortunately I don't have access to > this reader anymore.
I do not plan to integrate untested patches. If nobody can test that the code works then I can't help. Bye -- Dr. Ludovic Rousseau _______________________________________________ Muscle mailing list [email protected] http://lists.drizzle.com/mailman/listinfo/muscle
