On Fri, Aug 29, 2008 at 12:45 AM, Max Kellermann <[EMAIL PROTECTED]> wrote:
> Hi,
>
> this is the patch set I promised, which reduces MPD's memory usage.
> Have a lok at these benchmark results (for details look at the commit
> messages):
> tag: renamed functions, no CamelCase
Starting with this patch things started breaking:
mpd-audioOutput_shout.o: In function `myShout_setTag':
/tmp/mpd-mk/src/audioOutputs/audioOutput_shout.c:671: undefined
reference to `freeMpdTag'
/tmp/mpd-mk/src/audioOutputs/audioOutput_shout.c:678: undefined
reference to `mpdTagDup'
mpd-audioOutput_shout.o: In function `freeShoutData':
/tmp/mpd-mk/src/audioOutputs/audioOutput_shout.c:96: undefined
reference to `freeMpdTag'
It gets a bit worse in master:
source='audioOutputs/audioOutput_fifo.c'
object='mpd-audioOutput_fifo.o' libtool=no \
depfile='.deps/mpd-audioOutput_fifo.Po'
tmpdepfile='.deps/mpd-audioOutput_fifo.TPo' \
depmode=gcc3 /bin/sh ../depcomp \
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I.. -Wall
-Wextra -Wno-deprecated-declarations -Wmissing-prototypes
-Wdeclaration-after-statement -Wshadow -Wpointer-arith
-Wstrict-prototypes -pthread -D_REENTRANT -I/usr/include
-I/usr/include -I/usr/lib64 -pthread -D_REENTRANT -D_REENTRANT -g
-O2 -c -o mpd-audioOutput_fifo.o `test -f
'audioOutputs/audioOutput_fifo.c' || echo
'./'`audioOutputs/audioOutput_fifo.c
audioOutputs/audioOutput_shout.c: In function 'freeShoutData':
audioOutputs/audioOutput_shout.c:96: warning: implicit declaration of
function 'freeMpdTag'
audioOutputs/audioOutput_shout.c: In function 'copyTagToVorbisComment':
audioOutputs/audioOutput_shout.c:406: error: request for member 'type'
in something not a structure or union
audioOutputs/audioOutput_shout.c:408: error: request for member
'value' in something not a structure or union
audioOutputs/audioOutput_shout.c:411: error: request for member
'value' in something not a structure or union
audioOutputs/audioOutput_shout.c:414: error: request for member
'value' in something not a structure or union
audioOutputs/audioOutput_shout.c: In function 'myShout_setTag':
audioOutputs/audioOutput_shout.c:678: warning: implicit declaration of
function 'mpdTagDup'
audioOutputs/audioOutput_shout.c:678: warning: assignment makes
pointer from integer without a cast
audioOutputs/audioOutput_shout.c: At top level:
audioOutputs/audioOutput_shout.c:691: warning: initialization from
incompatible pointer type
make[3]: *** [mpd-audioOutput_shout.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory `/tmp/mpd-mk/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/tmp/mpd-mk/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/tmp/mpd-mk'
make: *** [all] Error 2
Thanks for all the hard work, it's great to have tons of work being
done to the daemon.
--
avuton
--
"I've got a fever. And the only prescription is more cowbell." --
Christopher Walken
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
