Hi people,

Just a quick fix for an api-breakage in git.
With commit 6dcd7fea (if I am not mistaken) the error returned when you 
try to save to an existing playlist is wrong.
Instead of MPD_ACK_ERROR_EXIST, MPD_ACK_ERROR_NO_EXIST is returned. This 
is obviously wrong and breaks gmpc.

Appended is a small patch to fix this.


diff --git a/src/command.c b/src/command.c
index 28b6ee3..0406c4e 100644
--- a/src/command.c
+++ b/src/command.c
@@ -238,7 +238,7 @@ static int print_playlist_result(int fd, enum 
playlist_result result)
         return -1;
 
     case PLAYLIST_RESULT_LIST_EXISTS:
-        commandError(fd, ACK_ERROR_NO_EXIST,
+        commandError(fd, ACK_ERROR_EXIST,
                  "Playlist already exists");
         return -1;
 

Furthermore I would like to request, once again, a way for the client to 
see if the/a playlist(s) have changed.
Now there is no way for me to detect if another client modfied, added or 
removed a playlist.
I know the listener protocol will probably solve this, but given that it 
could take a while before that is implement and I have rewritten gmpc to 
support it  I could use a workaround now. A simple counter that updates 
on a change is sufficient for me, to have it atleast consistent between 
clients.

2nd thing is, what are we going todo to the spam on this dev list? is 
shank the only one with access to the mailinglist settings?o

3rd thing, is there a roadmap? I want to make one for gmpc, but without 
one for mpd....

4th thing, what is going to happen with normalperson and cirrus mpd 
version. As client developer I am getting nervous seeing two separate 
branches I have to support. Because there are different plans as of 
features to implement in mpd this will be a problem for me in the future.

5th. What is the current state of mpd? when will there be a next 
release? See 3rd question...  

6th. What are we going to do with the mpd website?

7th. What is the state of the 30% cpu usage, alsa output bug? I kind of 
lost track of it. But the reports people still make, it is still an issue.

8th. Should we setup an automated "mirror" of git on f.e. repo.or.cz? of 
mpd/libmpdclient/ncmpc etc?

9th. Normalperson is it possible to setup an automated mirror of my 
repos on git on git.musicpd.org??

This concludes my 10 question game, more to come....

 Thx,

 Q

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team

Reply via email to