On 2008/11/20 17:31, Kodest <[EMAIL PROTECTED]> wrote: > And the following line comes up in the configure stdout: > checking for broken libfaad headers... broken > > HAVE_FAAD_LONG is defined. So the following lines in the aac plugin > are compiled which triggers the warnings: > 259: unsigned long *sample_rate_r = (unsigned long*)&sample_rate; > 323: unsigned long *sample_rate_r = (unsigned long*)&sample_rate;
What type does NeAACDecInit2() expect on your machine? It's "unsigned long *samplerate" on the latest unmodified release (2.6.1), and it compiles without warnings here. > My very simple idea to resolve this situation (not the union-based > one): cast the int32_t pointer argument to void* at the calling like > the attached patch. It compiles without any warnings and runs as well. > What do you think about it? (The patch makes the HAVE_FAAD_LONG define > unneeded.) There are compilers which don't like implicit void* to anything* casting, and emit a warning in this case. However libfaad2 seems to be so horribly broken, that this might be our solution, if all else fails. Max ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
