On Wed, Dec 14, 2011 at 11:31 AM, Jonathan Neuschäfer <j.neuschae...@gmx.net> wrote: > On Tue, Dec 13, 2011 at 12:16:18AM +0100, Max Kellermann wrote: >> On 2011/12/12 22:39, Jonathan Neuschäfer <j.neuschae...@gmx.net> wrote: >> > Perhaps we should use system() instead of fork and exec. Max? >> >> system() is easier to use and portable, but fork() gives you more >> control; for example, you could try a list of executables in one child >> process, instead of having to fork for every attempt. >> >> Portability is important, as Avuton is preparing a WIN32 build. If >> the feature is made in a way that is not portable, it should be >> auto-disabled (with #if) on incompatible platforms, or there should be >> a fallback. > > Speaking of it, how well does the lyrics screen work on Windows?
It doesn't, it's been configure'd out since win32; I don't really know enough to make this port happen: i586-mingw32msvc-gcc -std=gnu99 -DHAVE_CONFIG_H -I. -lpdcurses -I/home/avuton/src/mpd-release-utils/build-dir/include -mms-bitfields -I/home/avuton/src/mpd-release-utils/build-dir/include/glib-2.0 -I/home/avuton/src/mpd-release-utils/build-dir/lib/glib-2.0/include -DLOCALE_DIR=\""/home/avuton/src/mpd-release-utils/build-dir/share/locale"\" -DSYSCONFDIR=\""/home/avuton/src/mpd-release-utils/build-dir/etc"\" -I/home/avuton/src/mpd-release-utils/build-dir/include -DNDEBUG -O0 -ggdb3 -gstabs -pipe -Wall -Wextra -Wno-deprecated-declarations -Wmissing-prototypes -Wshadow -Wpointer-arith -Wstrict-prototypes -Wcast-qual -Wwrite-strings -c -o src/screen_text.o src/screen_text.c src/plugin.c:27:24: error: sys/signal.h: No such file or directory src/plugin.c:28:22: error: sys/wait.h: No such file or directory src/plugin.c: In function ‘plugin_eof’: src/plugin.c:147: warning: implicit declaration of function ‘waitpid’ src/plugin.c:150: warning: implicit declaration of function ‘WIFEXITED’ src/plugin.c:150: warning: implicit declaration of function ‘WEXITSTATUS’ src/plugin.c: In function ‘start_plugin’: src/plugin.c:253: warning: implicit declaration of function ‘pipe’ src/plugin.c:263: warning: implicit declaration of function ‘fork’ src/plugin.c:283: warning: passing argument 2 of ‘execv’ from incompatible pointer type /usr/lib/gcc/i586-mingw32msvc/4.4.4/../../../../i586-mingw32msvc/include/process.h:118: note: expected ‘const char * const*’ but argument is of type ‘char **’ src/plugin.c: In function ‘plugin_stop’: src/plugin.c:397: warning: implicit declaration of function ‘kill’ > It calls mkdir with two arguments, which Avuton changed in the conf > code in release-0.19-59-g3aea924, the plugin code uses bare FDs and > fork/exec, and the current plugins use shell script, ruby and python, > so at least plugin.c whould have to be changed as well to avoid these > unix-isms. > > Thanks, > Jonathan Neuschäfer That would definitely be cool. -- avuton -- If someone nearby has an iphone and leaves it near you, be aware they may be spying on you. ------------------------------------------------------------------------------ 10 Tips for Better Server Consolidation Server virtualization is being driven by many needs. But none more important than the need to reduce IT complexity while improving strategic productivity. Learn More! http://www.accelacomm.com/jaw/sdnl/114/51507609/ _______________________________________________ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
