On 2012/01/04 23:06, Allen Haim <al...@netherrealm.net> wrote:
> Alright, here it is with diff -u (but still against the stable version).
>
> Maybe this is more useful?
Yes, I can read the patch now (manually), but your mail client broke
the tab indentation. Don't allow your mail client to modify the patch
text!
A few comments (I did not really try to understand your changes yet,
so this is mostly formal stuff):
> +
> + PLAYER_COMMAND_PLAY_IMMEDIATE,
Please add documentation. The player code and mpd's thread
interaction is really complicated and hard to understand, and I think
it's important to have everything documented.
> +
> + bool next_immediately;
Same here: documentation, please.
> static struct music_buffer *player_buffer;
> @@ -145,6 +147,7 @@
> *
> * Player lock is not held.
> */
> +
> static void
> player_dc_start(struct player *player, struct music_pipe *pipe)
Unnecessary empty line was added.
> + case PLAYER_COMMAND_PLAY_IMMEDIATE:
> + player->next_immediately = 1;
This is a bool, and the value should be "true", not "1". This is C99!
> + assert(dc->pipe == NULL || dc->pipe == player.pipe);
> + if (player.xfade == XFADE_ENABLED) dc->command =
> DECODE_COMMAND_STOP;
> + player.next_immediately = 0;
Same here.
>
> + case PLAYER_COMMAND_PLAY_IMMEDIATE:
> +
> case PLAYER_COMMAND_PAUSE:
Is this fall-through intended?
> if (pc.thread == NULL)
> MPD_ERROR("Failed to spawn player task: %s", e->message);
> }
> +
Another empty line added.
------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual
desktops for less than the cost of PCs and save 60% on VDI infrastructure
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
_______________________________________________
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
