On Mon, 2013-06-24 at 16:13 +0200, Max Kellermann wrote: > On 2013/06/19 23:54, Alexander Sulfrian <alexan...@sulfrian.net> wrote: > > I created a patch to specify a custom cookie path for a pulse > > output. If you have multiple pulse outputs it could be difficult to > > synchronize all the pulse cookies.
Hi, > The whole point of your patch is to have multiple pulse cookies, but > that's exactly where your patch fails: it's not thread-safe in the > presence of multiple pulse outputs, is it? oh thats true. Maybe we want simply lock this region. I reworked the patch and add a static Mutex to the PulseOutput struct. So that the lock should affect all pulse outputs but nothing else. Here is the new patch: http://git.animux.de/mpd/commit/?h=custom-cookie-path&id=a5644308c5937b02d9331de136046772b013eb15 Hope that this is fine. If not please give me advice how to make the code thread safe. Thanks, Alex ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
