[PATCH 3 of 3] Equivalent mutt_buffy, but readable code

[Aron Griffis]

# HG changeset patch
# User Aron Griffis <agrif...@n01se.net>
# Date 1240341028 14400
# Branch HEAD
# Node ID b3d1d6043af677bd66727e9571e35bb66d5751f8
# Parent  ac4a424cf762c69b59e171c3b5ff333aad264436
Equivalent mutt_buffy, but readable code

Signed-off-by: Aron Griffis <agrif...@n01se.net>

diff --git a/buffy.c b/buffy.c
--- a/buffy.c
+++ b/buffy.c
@@ -508,57 +508,30 @@
  */
 void mutt_buffy (char *s, size_t slen)
 {
-  int count;
   BUFFY *tmp = Incoming;
+  int pass, found = 0;
 
   mutt_expand_path (s, slen);
-  switch (mutt_buffy_check (0))
+
+  if (mutt_buffy_check (0)) 
   {
-  case 0:
+    for (pass = 0; pass < 2; pass++)
+      for (tmp = Incoming; tmp; tmp = tmp->next) 
+      {
+       mutt_expand_path (tmp->path, sizeof (tmp->path));
+       if ((found || pass) && tmp->new) 
+       {
+         strfcpy (s, tmp->path, slen);
+         mutt_pretty_mailbox (s, slen);
+         return;
+       }
+       if (mutt_strcmp (s, tmp->path) == 0)
+         found = 1;
+      }
 
-    *s = '\0';
-    break;
+    mutt_buffy_check (1); /* buffy was wrong - resync things */
+  }
 
-  case 1:
-
-    while (tmp && !tmp->new)
-      tmp = tmp->next;
-    if (!tmp)
-    {
-      *s = '\0';
-      mutt_buffy_check (1); /* buffy was wrong - resync things */
-      break;
-    }
-    mutt_expand_path (tmp->path, sizeof (tmp->path));
-    strfcpy (s, tmp->path, slen);
-    mutt_pretty_mailbox (s, slen);
-    break;
-
-  default:
-    
-    count = 0;
-    while (count < 3)
-    {
-      mutt_expand_path (tmp->path, sizeof (tmp->path));
-      if (mutt_strcmp (s, tmp->path) == 0)
-       count++;
-      else if (count && tmp->new)
-       break;
-      tmp = tmp->next;
-      if (!tmp)
-      {
-       tmp = Incoming;
-       count++;
-      }
-    }
-    if (count >= 3)
-    {
-      *s = '\0';
-      mutt_buffy_check (1); /* buffy was wrong - resync things */
-      break;
-    }
-    strfcpy (s, tmp->path, slen);
-    mutt_pretty_mailbox (s, slen);
-    break;
-  }
+  /* no folders with new mail */
+  *s = '\0';
 }