On Monday, 01 August 2011 at 19:02, Phil Pennock wrote: > On 2011-08-01 at 10:53 -0700, Brendan Cully wrote: > > On Monday, 01 August 2011 at 07:18, Phil Pennock wrote: > > > +#if OPENSSL_VERSION_NUMBER >= 0x0090806fL && !defined(OPENSSL_NO_TLSEXT) > > > I'd prefer an autoconf test for SSL_set_tlsext_host_name instead of > > the version check above. I think it's more reliable. > > Hrm, it's not a cross-vendor issue of testing for availability, since > there's only one origin piece of software and they document its origin.
It's still better to test for functionality directly, instead of going by a version number (the additional OPENSSL_NO_TSLEXT hints at this). > Life's too short to willingly deal with autoconf, so I'll let this one > drop. Ah well. AC_CHECK_FUNCS would have done the job pretty easily. Ah well.
