On Thu, Aug 22, 2013 at 10:51:12AM -0500, Derek Martin wrote:
> THAT said, I'm betting there are other places in the code where there
> are BUFFER structs which aren't initialized properly.  Might be worth
> creating a function/macro to initialize these things properly... e.g.:

In fact, such functions already exist, though I think they could be
improved a bit or additional ones provided, so, for example, the user
doesn't need to allocate the data buffer (as my suggested
implementation in my previous e-mail does).  Though, there are several
ways to handle the memory allocation, which might beg for a few
different versions of the constructor... which I won't elaborate on as
I suppose it's obvious enough and probably not very interesting.

In any event, having found the mutt_buffer_* functions (in protos.h
and muttlib.c), I think the initializations should use those functions
instead of calling memset().

-- 
Derek D. Martin    http://www.pizzashack.org/   GPG Key ID: 0xDFBEAD02
-=-=-=-=-
This message is posted from an invalid address.  Replying to it will result in
undeliverable mail due to spam prevention.  Sorry for the inconvenience.

Attachment: pgp9U5X6fI_ty.pgp
Description: PGP signature

Reply via email to