#3705: mutt_sasl.c: 2 * possible bad test ?
--------------------+---------------------
 Reporter:  dcb314  |      Owner:  brendan
     Type:  defect  |     Status:  new
 Priority:  minor   |  Milestone:
Component:  IMAP    |    Version:
 Keywords:          |
--------------------+---------------------
 mutt_sasl.c:199:25: warning: logical not is only applied to the left hand
 side of comparison [-Wlogical-not-parentheses]

     if (!iptostring((struct sockaddr *)&local, size, iplocalport,
               IP_PORT_BUFLEN) != SASL_OK)

 Boolean 0 / 1 compared to SASL_OK. Looks like it might be a problem.
 Removing the double negative might also help.

 Same thing a few lines further down
 mutt_sasl.c:210:25: warning: logical not is only applied to the left hand
 side of comparison [-Wlogical-not-parentheses]

-- 
Ticket URL: <http://dev.mutt.org/trac/ticket/3705>
Mutt <http://www.mutt.org/>
The Mutt mail user agent

Reply via email to