So, I've been working on my opportunistic encrypt patch set again. I'm almost ready to send out the patches, but I'd like some feedback on (at least) one thing first.
The main changes compared to previously are: * I've added a bit to HEADER->security for OPPENCRYPT mode. This means you can toggle it on/off for an individual message. (More about this below). So oppenc is only active if *both* the crypt_opportunistic_encrypt option is set and the header bit is set. * If any other setting enables encryption for a message, such as crypt_autoencrypt or crypt_replyencrypt, then oppenc turns itself off for the message, so it doesn't fight with your other settings. * The status of oppenc is stored in a postponed/resumed message. * The status of oppenc is shown in the Security line on the compose message. If active, (OppEnc mode) will be appended to the line. * The <pgp-menu> and <smime-menu> menus do not show the (e)ncrypt or (b)oth options when oppenc is active. Also, the (c)lear function only clears the SIGN bit when it is active. Additionally (and this is where I could use feedback), the toggle function for oppenc has been added to these menus. The advantage of putting it here, is that it's where I believe makes the most sense. The disadvantage is that the menu line is longer, and there are more combinations of menus so the code is more complicated. I could easily create a new compose menu function, <toggle-oppenc>, but it wouldn't be quite as discoverable. Since the option is not enabled by default, though, people will probably read the documentation first and learn that keybinding. The patchset is a bit big, but when I post, I'll indicate the overall purpose of each patch and what has changed since last time. I'd appreciate any feedback about adding the toggle to the pgp-menu and smime-menu or creating a new compose menu function. Also, general feedback about whether this has a chance of being committed would be great. Thanks, -Kevin
signature.asc
Description: PGP signature
