Vincent Lefevre wrote: > On 2015-05-16 15:36:49 -0700, Kevin J. McCarthy wrote: > > This patch changes smime_keys.pl to use an open/pipe instead of > > backquotes for openssl execution. This avoids the shell and thus > > spaces, quote, and those kinds of issues. > > I think that you should check whether "close" fails.
Hi Vincent, Thanks for taking a look at the patch. My understanding was close() returns false and sets $? on error. Because the callers deal with non-zero exit values in different ways, I have them checking the value of $?. However, taking another look at close() in the perl book, I do see that $! may also be non-zero "if a syscall fails". I will add a check for that to the close() call (along with a comment that the callers are checking $?) and resend the patch later today. Does that sound good? Thanks, -Kevin
signature.asc
Description: PGP signature
