Oswald Buddenhagen wrote: > On Thu, Jun 18, 2015 at 04:06:41PM -0700, Kevin J. McCarthy wrote: > > Additionally, further down in imap_auth_sasl() there are a couple > > checks for whether method is NULL, so the NONULL check is not > > inconsistent inside the function. > > > i didn't look at that code, but the method could be plausibly null for > legitimate reasons (when the legacy LOGIN is the only supported method, > for example).
Sorry I wasn't clear, capstr is assigned to method if method is null, but there are still null checks for method further below. In any case, the parent patch is as much as I'm comfortable doing to fix the problem. Other improvements to the imap code should probably be done by someone more familiar with the code. -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA http://www.8t8.us/configs/gpg-key-transition-statement.txt
signature.asc
Description: PGP signature
