On Tue, Sep 29, 2015 at 07:23:57PM +0200, Oswald Buddenhagen wrote: > On Tue, Sep 29, 2015 at 03:30:27PM +0800, Kevin J. McCarthy wrote: > > least [one] character.
Fixed. Thank you.
> at face value, these fragments look too optimistic - the last line could
> have no trailing newline, even if erroneously. not sure if that can
> actually happen and whether it would be a problem, as i don't know the
> context. possibly add comments.
That's a good catch. I want to keep this commit focused on the oob
read, but will look at the context of those two snippets next.
It looks like they should both be changed to
if (len && (email[len - 1] == '\n'))
email[len - 1] = '\0';
but I'll take a closer look.
Thank you for the feedback!
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
http://www.8t8.us/configs/gpg-key-transition-statement.txt
signature.asc
Description: PGP signature
