Hi Everyone, After a week of terrible jet lag, I'm getting back to normal, and so getting back to mutt development.
One of my todos from ticket 3787 / changeset a6919571eb59 was to check
other uses of strchr to make sure we didn't unintentionally match '\0'
at the end of the string. I've spent this afternoon going through the
calls, and have 6 places that I think are worth fixing.
My question is if, inside mutt_multi_choice(), getch() can return 0
("NUL"). If so, should it be handled the same as an abort (<0) or as
"not one of the choices" and just loop again?
Right now, it would match the '\0' in letters and return an index all
the callers weren't expecting.
Any opinions?
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
http://www.8t8.us/configs/gpg-key-transition-statement.txt
signature.asc
Description: PGP signature
