On Mon, Mar 07, 2016 at 04:32:42PM -0800, Kevin J. McCarthy wrote: > Overall the patch looks fine. There are three small changes I'd like to > make (attached as a patch file): > > 1. Since uname sets errno, change the fputs to perror. > > 2. safe_strdup() checks for NULL params, so remove the redundant > NONULL(). > > 3. buffer is allocated on the stack, and can't be NULL, so remove the NONULL. > > If they look okay to you, I'll just test a bit more and push this out.
That's all fine, though one concern with perror is the error message is occasionally unintelligible or confusing in context. But it should really be impossible for uname() to fail, and the man page even indicates there are no defined errors. So it probably doesn't matter what you do there, in practice. -- Derek D. Martin http://www.pizzashack.org/ GPG Key ID: 0xDFBEAD02 -=-=-=-=- This message is posted from an invalid address. Replying to it will result in undeliverable mail due to spam prevention. Sorry for the inconvenience.
pgpGLHWOqXqqb.pgp
Description: PGP signature
