On Tue, Mar 08, 2016 at 04:39:57PM +0000, Richard Russon wrote: > > How do you ensure data integrity of, say, an mbox mailstore if you're > > not locking? > > Don't know. > > https://github.com/neomutt/neomutt/commit/5adde051f0ae67bfc8aeea0a26060c4e6b0685e4
Yeah, looked into this for a minute, and determined it's atrocious. Should lead to mail store corruption unless you're only using maildir. The fact that Mutt isn't multithreaded is not interesting; the fact that multiple processes (e.g. your MDA) may read and write the mail store files simultaneously IS. Locking is important, and this patch is misguided. > This effectively hides the message, but also hides messages you may want > to see. > > https://github.com/neomutt/neomutt/commit/d53c0bb24d98635f3264fc1a99d38ec10c071584 Yeah, this is much less harmful, but I personally would want it dumped due to that "hides messages you may want to see" part. But I also don't use TLS since I read mail locally. But I don't remember seeing it when I used IMAPS--is it new (for some definition of "new" relevant for Mutt)? :) > Bye srandom() and random() This is fine--just not clear that it's worth departing from upstream. There's been discussion about doing something like this for temporary file names in the past but what the OS provides by default has been deemed "good enough" by the experts... > > Why? > > https://github.com/neomutt/neomutt/commit/6fa23faa08b19e1748ca20505abddfb47293a906 > > OK, the patch doesn't change Mutt. Notmuch uses strndup and the patch > is a build workaround for systems that don't support it. Yeah, again I personally would dump this. I've been meaning to have a look at how mutt uses the n functions for quite a while; in principle I'd like to see them removed entirely, though they do have their uses. -- Derek D. Martin http://www.pizzashack.org/ GPG Key ID: 0xDFBEAD02 -=-=-=-=- This message is posted from an invalid address. Replying to it will result in undeliverable mail due to spam prevention. Sorry for the inconvenience.
pgpGu709UcpyO.pgp
Description: PGP signature
