On Thu, Apr 21, 2016 at 03:09:54AM +0100, Richard Russon wrote: > I've ported the Sidebar and given your patches a bit of a test-drive. > Looking good.
That's good news. > I've attached a couple of suggested changes. > * A patch fix the compile under slang > * A refactoring of mutt_reflow_windows() Thank you for the fixes. I will add those both in. > For fun, I added a '$sidebar_on_right' variable, which works OK-ish. > > Problems encountered so far: > The pager still uses some clrtoeol()s overwriting my right-Sidebar I wonder if this is because it is inserting a '\n' to terminate lines. I recall seeing a comment that this intrinsically inserts a clrtoeol() for either ncurses or slang. > mutt_FormatString() still references COLS > > Fixing mutt_FormatString() isn't too hard, but it's used in over 40 > places, so it'll be a bit tedious. Would you like me to look at it? That's okay, I've got it on my list. 99% of the callers want it to be for MuttIndexWindow, so my plan was making mutt_FormatString() a proxy to a new function that has a maxcols parameter. mutt_FormatString() would pass MuttIndexWindow->cols(), but other callers would want to use the new function pass their window columns. -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA http://www.8t8.us/configs/gpg-key-transition-statement.txt
signature.asc
Description: PGP signature
