On Sun, May 01, 2016 at 07:26:53PM -0700, Kevin J. McCarthy wrote: > On Sun, May 01, 2016 at 07:02:38PM +0200, Vincent Lefevre wrote: > > On 2016-04-26 09:54:48 -0700, Kevin J. McCarthy wrote: > > > David, Brendan, Vincent (and anyone else), does the prefix 'MUTT_' sound > > > reasonable, or is there another prefix that would be better? > > > > It is reasonable, but as reasonable as M_ (for a prefix used > > internally). If systems can break M_, they could break almost any > > prefix (if particular if it corresponds to something readable).
The difference is the OS is using M_, and such short prefixes are common for OS-level libraries. It's not so surprising that there's a conflict here. Whereas using MUTT_ instead--I'm certainly unaware of any other software that uses it, and for a new project to start Mutt clearly has been around a lot longer... What is the likelihood that you'd find a conflict in a library that's meant to compile with Mutt, or which Mutt itself requires to compile? Methinks pretty slim... :) > The patch now in 1.6.1 "fixes" this issue for mutt, but it's an ugly > band-aid. While I'm in no hurry to make such a large change to our > code, Derek is right that now's as good a time as there is. I've > already made some pretty large changes with the windows patch-set, so > the next default-branch release is already going to cause pain to > external patches. FWIW I was busy this weekend and totally forgot about this... I'll try to find some time this week. I think the perl command that Andras gave is adequate to produce the required change; I'd just want to do something slightly more complicated to identify any conflicts first. > > Now, if it is OK to break patches, how about doing some other clean-up > > at the same time? I mean, document code styling and make it uniform, > > and fix typos in comments. > > Yes, that sounds okay too. I'll start a wiki page this week with what I > perceive as the code styles. If we want to make large-scale changes, I > would ideally like to designate a tool to do those (so we can easily > verify the patches). I've always wanted software projects to generate a configuration for indent, and then run it on every submission... or something of the sort. -- Derek D. Martin http://www.pizzashack.org/ GPG Key ID: 0xDFBEAD02 -=-=-=-=- This message is posted from an invalid address. Replying to it will result in undeliverable mail due to spam prevention. Sorry for the inconvenience.
pgp4ov4kazWZ5.pgp
Description: PGP signature
