On Wed, Jun 01, 2016 at 12:52:10PM -0700, Kevin J. McCarthy wrote:
> The biggest thing right now is help making sure I didn't break things
> with my changes (mostly in patch 03).
I can't find anything obvious.
There's one slight issue with the status bar length, but that appears in
the original win-sidebar patch (I'll investigate when I have a second).
> I gutted a chunk of your work on the manual,
> I think it's a nice introduction,
> which you probably don't want to abandon.
You're right, I don't.
> and am not sure it's needed in the manual so for now I
> just took it out.
Then suggest where it should go.
> but I was having a ton of validation errors
Hmmm... It seems like valid xml/docbook to me.
> One thing you can probably whip out much
> faster than I would be a new format string. I'd like the be able to use
> the sidebar with just a "N" flag, (based on the BUFFY->new).
'N' is already in use (by quite a lot of Sidebar users)
Change it to use BUFFY's new
diff --git i/sidebar.c w/sidebar.c
index ba23d33..27ae988 100644
--- i/sidebar.c
+++ w/sidebar.c
@@ -192,9 +192,9 @@ static const char *cb_format_str(char *dest, size_t
destlen, size_t col, int col
if (!optional)
{
snprintf (fmt, sizeof (fmt), "%%%sd", prefix);
- snprintf (dest, destlen, fmt, b->msg_unread);
+ snprintf (dest, destlen, fmt, b->new);
}
- else if (b->msg_unread == 0)
+ else if (b->new == 0)
optional = 0;
break;
---
Or, add 'n' for BUFFY's new
diff --git i/sidebar.c w/sidebar.c
index ba23d33..4558a3d 100644
--- i/sidebar.c
+++ w/sidebar.c
@@ -188,6 +188,16 @@ static const char *cb_format_str(char *dest, size_t
destlen, size_t col, int col
optional = 0;
break;
+ case 'n':
+ if (!optional)
+ {
+ snprintf (fmt, sizeof (fmt), "%%%sd", prefix);
+ snprintf (dest, destlen, fmt, b->new);
+ }
+ else if (b->new == 0)
+ optional = 0;
+ break;
+
case 'N':
if (!optional)
{
---
Rich
