On Thu, Jul 14, 2016 at 06:32:52PM -0500, Will Fiveash wrote: > On Wed, Jul 13, 2016 at 07:47:04PM -0700, Kevin J. McCarthy wrote: > > There is a len field, but I'd also still like to see the account->pass > > nul-terminated. I see plugins/plugin_common.c doing that in the sasl > > source (when they prompt, not when they call the callback), so it's > > probably a good idea. > > I disagree. SASL does not expect the data field in sasl_secret_t to be > treated as a string and adding a terminating '\0' is just complicating > the code. I'm assuming that's because the secret data could in fact be > any binary byte values including '\0'.
Okay, if you are confident that's the case, it's fine with me. Today is a little crazy, but I'll test it too and push it out tonight or tomorrow. Thank you for the patch! -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
