#3880: integer overflow in date.c (mutt_mktime)
-----------------------+----------------------
Reporter: vinc17 | Owner: mutt-dev
Type: defect | Status: closed
Priority: critical | Milestone:
Component: mutt | Version: 1.7.0
Resolution: fixed | Keywords:
-----------------------+----------------------
Comment (by derekmartin):
I'd like to suggest a differernt fix for this, with the following
properties:
- Simplifies mutt_mktime() greatly
- uses the system mktime()
- removes an additional function (compute_tz())
- provides an alternative implementation of mutt_local_tz()
- should eliminate the overflow
- dispenses with the awful macro to get time_t's max value, which
produces warnings on MacOS
- produces identical results to the original implementation of
mutt_mktime()
- Tests correctly with the test program I attached to bug #3890.
--
Ticket URL: <https://dev.mutt.org/trac/ticket/3880#comment:26>
Mutt <http://www.mutt.org/>
The Mutt mail user agent