On Sat, Dec 03, 2016 at 08:53:58PM -0500, Damien Riegel wrote: > To comply with XDG Base Directory Specification, look for Muttrc in > folders listed in XDG_CONFIG_DIRS. > --- > init.c | 58 ++++++++++++++++++++++++++++++++++++++++++++++------------ > muttbug.sh.in | 3 ++- > 2 files changed, 48 insertions(+), 13 deletions(-)
Concatenating all the combined dirs into buffer (size STRING) is probably not a great idea. In fact, although I didn't catch it, we should really be using a buffer of size _POSIX_PATH_MAX in mutt_find_cfg(). I'd like to see the files[] inside of mutt_find_sys_cfg(), instead of exposed like that. Quickly commenting on the other patches here. In patch 2, you shouldn't move the overwrite of AliasFile after you have sourced the system muttrc. I'm not crazy about either patches 3 and 4, but will think about them. -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
