About 7 years ago, I did some basic code style cleanup.
* Commit 443295ee: Remove trailing whitespace.
The result of
find . -name "*.[ch]" -exec emacs -batch {} \
--eval="(progn (delete-trailing-whitespace) (and (buffer-modified-p)
(save-buffer)))" \;
* Commit 248c2ee8: Clean up code indentation.
These are mostly automated changes corresponding to the emacs
settings:
(c-set-style "linux")
(setq c-basic-offset 2)
(c-set-offset 'case-label '+)
Most of the code follows the convention:
(add-to-list 'c-cleanup-list 'space-before-funcall)
but this is not enforced by this indentation cleanup.
Also, I personally dislike tabs, so I have:
(setq-default indent-tabs-mode nil)
in my own configuration. However I have no desire to change every line
just for that effect. So this cleanup does nothing about the mix issue.
* Commit efa3afb5: Clean up formatting.
Add spaces after if, else, while, for, switch.
Unify the brace placement style. The vast majority of the code uses
Allman style so convert the relatively few K&R braces over.
You'll notice in the second commit I declined at that time to do
anything about the tabs vs spaces indentation split. The code base is
fairly evenly divided between the styles. However, if we now use git
send-email more for review, that leads to readability issues.
I don't have a rabid preference about this, but I personally like spaces, and if we're going to go one way or another, I'd like to convert the code base to spaces, using e.g. "expand" or similar utility.
To avoid making stable branch commit merges back to master a nightmare during 2.3.x maintenance, I'd prefer to do this close to the end of the 2.4.0 development cycle. If someone is interested in doing this, please speak up, otherwise I'll just run "expand" and commit it close to the end of the cycle.
-- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
