This addresses ticket #386. Currently Mutt relies on gpg to perform conversion to and from CRLF, via the --textmode parameter passed to various commands.
While there is nothing wrong with this, the parameter is marked as "legacy" in the gpg man page, and not all tools support it. To avoid possible portability issues in the future, change mutt to perform its own conversion. (Note however, that there is more to the story than just swapping tools. Verifying signing and decryption currently requires carefully parsing the gpg output to check for spoofing.) Note: I've again broken this patch into bite-size chunks, for what I hope is easier review. I'll be happy to squash to a single commit afterwards if this upsets anyone. Kevin J. McCarthy (6): Add library functions to convert between CRLF and LF. Convert pgp_decrypt_part() to use textmode conversion function. Convert pgp_sign_message() to perform textmode handling. Convert pgp_encrypt_message() to perform textmode handling. Convert pgp_traditional_encryptsign() to perform textmode conversion. Convert pgp_application_pgp_handler() to perform textmode conversion. muttlib.c | 63 ++++++++++++++++++ pgp.c | 190 ++++++++++++++++++++++++++++++++++-------------------- protos.h | 2 + 3 files changed, 186 insertions(+), 69 deletions(-) -- 2.53.0
