On Fri, May 08, 2026 at 06:08:37AM +0200, Rene Kita wrote:
> > + /* dir is empty, just append the file name */
> This comment ...
> > + /* dir is not empty, append it */
> ... and this ...
So, the reason I commented this so verbosely is precisely because,
like I have seen so many times before, Mutt did this incorrectly for
years (albeit with no noticeable consequences, unlike in other places
I've seen it). I think it is worth calling out very explicitly the
fact that there are more cases than one can solve with the common
sprintf(buf, "%s/%s", dir, fname);
paradigm that so typically is used for this. Same reason I wanted the
branches explicitly written out. This is a common pattern that is
almost invariably oversimplified.
"Explicit is better than implicit." --Guido van Rossum (and me!)
--
Derek D. Martin http://www.pizzashack.org/ GPG Key ID: 0xDFBEAD02
-=-=-=-=-
This message is posted from an invalid address. Replying to it will result in
undeliverable mail due to spam prevention. Sorry for the inconvenience.
