Re: [PATCH] Add filename filters when saving attachments.

[Kevin J. McCarthy]

On Sat, May 09, 2026 at 02:02:54PM +0200, Alejandro Colomar via Mutt-dev wrote:

I could also simply filter only "/" -> "_", which might be all we need
to do.  Comments?

I think I'd do the simplest change.  And if we want to do more, maybe
split that into its own commit, with a different justification in the
commit message.

I'm inclined to do that, and go with just "/" -> "_" too. I'll wait to see what others say, but it seems like just removing "/" should be enough.

+    {
+      if (*filename == '/' || !IsPrint((unsigned char) *filename))

AFAICS, IsPrint() already does the necessary cast.

--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C  5308 ADEF 7684 8031 6BDA

Thanks! My mistake for grabbing it from elsewhere and not checking it. :-)

signature.asc
Description: PGP signature