On Tue, Aug 25, 2026 at 12:51:14PM +0200, Alejandro Colomar via Mutt-dev wrote:
Date: 2026-08-25 18:00:24+0800 From: "Kevin J. McCarthy" <[email protected]>[...]diff --git a/rfc1524.c b/rfc1524.c index f1b13fc9..b14436c1 100644 --- a/rfc1524.c +++ b/rfc1524.c @@ -494,9 +494,9 @@ int rfc1524_mailcap_lookup(BODY *a, char *type, size_t typelen, rfc1524_entry *e * template and/or the old file name will be used for the * comparison and the temporary file name. */ -void mutt_rfc1524_expand_filename(const char *nametemplate, - const char *oldfile, - BUFFER *newfile) +static void _rfc1524_expand_filename(const char *nametemplate, + const char *oldfile, + BUFFER *newfile)It's technically undefined behavior to declare an identifier starting with '_lowercase' in file scope. (I ignore if we already have of those, and thus this is just consistent with existing practice; also, it's unlikely that glibc will define anything similar, so it should be fine.) Feel free to ignore this comment. :)
There's a sprinkle like this, but not so many that it I need to add another on. I'll fix it. Thank you!
-- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
