Hi Christian, On Mon, Nov 29, 2010 at 11:11:11AM +0100, Christian Ebert wrote: > Ah, nice, something I wanted to do for a long time. But it's > always easier to nitpick on others ;-) I did the following to > make it work - veeery quick and dirty, but might give you some > ideas: > > [...] > > 1) consistently using <commands> might be a good idea - in case > someone decides to remap "/" ;-)
It used to be like this, but I changed it in commit 6fde4fd [1]. The reason was that with the simple commands one layer less of quoting was required... I always had to use two screen commands when using <commands>. Another advantage: mutt's history doesn't fill up with useless long <commands> :-). But you are right, it would be "cleaner" to use them! > 2) Avoid problems with $wrap_search by jumping to 1st message. That's a good point, I wasn't aware that you can switch that off! > 2) I for one set $uncollapse_jump in folder-hooks, therefore > "simulate" search to be independent of setups. Ok, the search simulation works, but wouldn't make that jumping to the first message unnecessary? > 4) The screen code obviously does not belong there, I put it in > just for brevity and to point you to screen -X and $STY. You > might even be able to avoid some "screen stuff" commands in > the screen section. I wasn't quite aware of $STY! Are you suggesting auto-recognition of SCREEN mode? The problem is, that one might want to use screen even if mutt is not started in screen (not that probable), or that one wants the normal operation even when in screen (perhaps more probable). Or am I not getting something relevant here :-)? > 5) ps has no --no-heading option here on Mac OS X (BSD-like). Already changed, thanks! [1] https://github.com/weisslj/muttjump/commit/6fde4fdd7fa12b76a3a4136dff96266c05088b97 Johannes
pgpzWk8icaI4W.pgp
Description: PGP signature
