Makoto Terada wrote:
> Hi martin.
>
> Thunderbird3.0a2pre can open message or folder in new tab.
> So I create this patch opens in new tab and move to next/previous tab
>
> Command:
> :tabo[pen]
> open the selected message in new tab
> :tabo[pen]!
> open the selected folder in new tab
> :tabo[pen] Server/folder/slash/separeted/path
> open the specified folder in new tab
>
> Mapping:
> gt
> Go to the next tab
> gT
> Go to the previous tab
>
> Any suggestions ?
Yeah, functionality-wise this patch seems fine, but I just can't merge it this
way. My suggestions:
1.) :tabopen should only work on messages, not folders, that's what we have
:goto for.
:tabopen should just work like :open, as I told you on IRC, but until we have
this behavior,
:tabopen without arguments might just open the current message in a new tab.
You should be able to use :tab goto inbo<cr> however.
Furthermore, I propose an "I" mapping to inspect a message in a new tab, just
like 'i' inspects it in
the current tab.
2.) The tabs: (function() ...
functionality should be integrated in tabs.js. There just is too much
duplication in the indexFromSpec and select methods.
3.)
> + getAllFolderPathes: function()
> + {
> + function getPath(folder) folder.parent ? getPath(folder.parent)
> + "/" + folder.prettiestName : folder.prettiestName;
> + return this.getFolders("",true,true).map(function(f) f.isServer
> ? [f.prettiestName, f.URI] : [getPath(f), f.URI]);
> + },
3a) should be private i guess?. Actually since it is only needed in the
completer, it could
be moved inside the completer.
3b) should be named getAllFolderPaths (without an e)
3c) function getPath(folder) without {} after it? looks strange at least
4.) + if (list[i].indexOf(arg) != -1){
The { should be on a line of its own.
These are the most obvious changes needed for the patch to be accepted.
I have not tested the patch out yet, but I will when you provide an updated
patch.
best regards,
Martin
_______________________________________________
Muttator mailing list
[email protected]
https://www.mozdev.org/mailman/listinfo/muttator
