Hi Jon...
[EMAIL PROTECTED] wrote:
> On Wed, 10 Jan 2007 20:59:22 CST, stuart wrote:
>> Hi GC...
>>
>> Just wanted to report: I compiled Ozzy's patch and it appears to work.
>> I'll try switching to the more probable solution of calling the ulong
>> instead of the long function later. Jon, Simon, David and Eric appear
>> to be the authors of the effected file (libs/libcmyth/socket.c) - so
>> I'll let them decide on how to fix this - unless I hear otherwise.
>
> I think it's wrong to change cmyth_rcv_long(). If myth is trying to
> send an unsigned long, then we should be interpreting the field as an
> unsigned long. If myth is passing an invalid number, then we should
> deal with the out of range error in cmyth_rcv_proginfo().
>
> I'll look at the various versions of myth and see whether this should
> be a signed value or not.
>
> Jon
I believe I have made the proper change to call the unsigned long
instead of the long mythtv function to handle the chanId value. I just
tried it and it appear to work as well. Would you consider this the
proper solution?
...thanks, Rick
...here's the diff of libs/libcmyth/socket.c. Note - (small as it is)
this is sloppy code and is here just to look at. I don't even think the
line numbers are right as I had made other code changes that I have only
commented out:
---------------------------------
1442,1444c1433
< /// #### consumed = cmyth_rcv_long(conn, err,
&buf->proginfo_chanId, count);
< printf("TEST>>Trying a unsigned long call to handle the chanId.\n");
///####
< consumed = cmyth_rcv_ulong(conn, err, &buf->proginfo_chanId, count);
---
> consumed = cmyth_rcv_long(conn, err, &buf->proginfo_chanId, count);
---------------------------------
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Mvpmc-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mvpmc-users
mvpmc wiki: http://mvpmc.wikispaces.com/
